[GLUTEN-8945][VL] Pull out duplicate projections in hash probe #8946
+126
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
rui-mo
reviewed
Mar 12, 2025
| /** | ||
| * Velox does not allow duplicate projections in hash probe, this rule pull out duplicate | ||
| * projections. | ||
| */ |
There was a problem hiding this comment.
Perhaps elaborate on what was the plan like, and what is the new plan like.
| } | ||
| } | ||
|
|
||
| def rewriteStreamPlan( |
There was a problem hiding this comment.
Please add comments for how stream plan is rewritten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Fixes: #8945)
How was this patch tested?
UT.